-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[WIP] Fix RedHat System.Globalization failures #24338
Conversation
@dotnet/eng-first are there currently any known issues with the CI on 2.0 branch? It doesn't seem to have started. |
@krwq The dev/release/2.0.0 branch isn't a tracked branch. Is this where you meant to make your PR? |
on Linux, it depends on what version of ICU is used on such distro with a specific version. On Windows, Windows is changing/adding globalization data almost every release. |
👍 |
@tarekgh seems like I have swapped Expected value with Actual when reading and reversed condition (should be || Rhel6.9) |
The expected value for the test case is [3, 2]. so I think using |
4c0d0ef
to
531e4ee
Compare
@tarekgh I believe [3] is correct expected value - that is what Win10/ICU 55+ is using (also what you wrote above) - !RedHat6.9 wouldn't change test result as we currently already expect [3,2] and seems like RHEL6.9 used by CI have ICU 55+. (note that UrINNumberGroupSizes returns expected value not actual and there is no reason any of the conditions in the if statement would be met) |
Closing this in favor of #24340 - this PR is improperly targeting dev/release/2.0.0 |
@krwq
|
@tarekgh true, I think we got both confused by this condition: |
This is WIP - I do not have RedHat to test, so currently using CentOS
https://github.com/dotnet/corefx/issues/24304
Original fix made by @tarekgh will require changes to CoreCLR (add ICU version detection to native code) which is likely not appropriate as servicing change which does not fix any product bugs.
Currently I do not understand why exactly RedHat 6.9 uses code path which is conditioned for Win10/OSX15+/Ubuntu14.04+/Fedora/Debian>8 and will investigate here - current state is sanity check to ensure straight forward change will pass on rhel and it is not i.e. Xunit swapping Expected/Actual labels.